Add missing await for API request #27676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`getAllPostsWithSlug` was missing an `await` on `fetchAPI`, resulting in `data?.allPosts` always returning `undefined`. This meant SSG wasn't aware of the paths it needed to generate.
jameshoward
requested review from
huozhi,
ijjk,
leerob,
lfades,
padmaia,
shuding,
styfle and
timneutkens
as code owners
timneutkens
approved these changes
Aug 2, 2021
|
Thanks! |
leerob
approved these changes
Aug 2, 2021
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Aug 19, 2021
`getAllPostsWithSlug` was missing an `await` on `fetchAPI`, resulting in `data?.allPosts` always returning `undefined`. This meant SSG wasn't aware of the paths it needed to generate.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getAllPostsWithSlugwas missing anawaitonfetchAPI, resultingin
data?.allPostsalways returningundefined. This meant SSG wasn'taware of the paths it needed to generate.